diff --git a/.planning/REQUIREMENTS.md b/.planning/REQUIREMENTS.md index 9bff1e5..ec11677 100644 --- a/.planning/REQUIREMENTS.md +++ b/.planning/REQUIREMENTS.md @@ -13,11 +13,11 @@ v2.0 (Phases 7–10) ha consegnato catalogo unificato, offerte con fasi, prevent | OFFER-08 | L'utente assegna tag multi-select a servizi/offerte, creando nuovi tag al volo senza uscire dalla tabella | Complete | | OFFER-09 | L'utente aggiunge un nuovo servizio/offerta tramite riga vuota in fondo alla tabella (nome + invio) | Complete | | OFFER-10 | L'utente filtra/cerca servizi e offerte istantaneamente (ricerca client-side, nessun reload) | Complete | -| OFFER-11 | L'admin compone un'offerta a 3 tier (A/B/C) assegnando i servizi del catalogo unificato `services` tramite matrice di checkbox (servizio × tier); il totale servizi di ogni tier si aggiorna live | Pending | -| OFFER-15 | Ogni offerta ha tag su 4 dimensioni (categoria, ticket, tipo, obiettivo) creabili al volo, riusando il sistema tag polimorfico di Phase 11 | Pending | -| OFFER-16 | Per ogni tier l'admin imposta un "prezzo pubblico" manuale, distinto e indipendente dal totale dei servizi | Pending | -| OFFER-17 | Ogni offerta ha una promessa di trasformazione strutturata (Cliente Ideale / Risultato / tempo / Pain / Metodo) | Pending | -| OFFER-18 | La lista offerte è filtrabile per categoria e supporta l'archiviazione (mostra/nascondi archiviate) | Pending | +| OFFER-11 | L'admin compone un'offerta a 3 tier (A/B/C) assegnando i servizi del catalogo unificato `services` tramite matrice di checkbox (servizio × tier); il totale servizi di ogni tier si aggiorna live | Complete | +| OFFER-15 | Ogni offerta ha tag su 4 dimensioni (categoria, ticket, tipo, obiettivo) creabili al volo, riusando il sistema tag polimorfico di Phase 11 | Complete | +| OFFER-16 | Per ogni tier l'admin imposta un "prezzo pubblico" manuale, distinto e indipendente dal totale dei servizi | Complete | +| OFFER-17 | Ogni offerta ha una promessa di trasformazione strutturata (Cliente Ideale / Risultato / tempo / Pain / Metodo) | Complete | +| OFFER-18 | La lista offerte è filtrabile per categoria e supporta l'archiviazione (mostra/nascondi archiviate) | Complete | | OFFER-13 | I dati legacy di `service_catalog` e `offer_services` sono consolidati in `services` senza perdita (migration additiva) | Complete | ## Workspace Progetto — Servizi Attivi (v1) @@ -95,11 +95,11 @@ Popolata dal roadmapper durante la creazione della roadmap. | OFFER-09 | Phase 11 | Complete | | OFFER-10 | Phase 11 | Complete | | OFFER-13 | Phase 11 | Complete | -| OFFER-11 | Phase 12 | Pending | -| OFFER-15 | Phase 12 | Pending | -| OFFER-16 | Phase 12 | Pending | -| OFFER-17 | Phase 12 | Pending | -| OFFER-18 | Phase 12 | Pending | +| OFFER-11 | Phase 12 | Complete | +| OFFER-15 | Phase 12 | Complete | +| OFFER-16 | Phase 12 | Complete | +| OFFER-17 | Phase 12 | Complete | +| OFFER-18 | Phase 12 | Complete | | OFFER-12 | Deferred (v2) | Rimandato 2026-06-14 | | PROJ-06 | Phase 13 | Pending | | PROJ-07 | Phase 13 | Pending | @@ -120,4 +120,4 @@ Popolata dal roadmapper durante la creazione della roadmap. --- *Requirements defined: 2026-06-13* -*Last updated: 2026-06-14 — Phase 12 re-scoped da mockup utente: editor offerte (OFFER-11 ridefinito + OFFER-15..18), import CSV OFFER-12 rimandato* +*Last updated: 2026-06-18 — Phase 12 complete: OFFER-11, OFFER-15, OFFER-16, OFFER-17, OFFER-18 → Complete* diff --git a/.planning/ROADMAP.md b/.planning/ROADMAP.md index 97a4900..bfe85d3 100644 --- a/.planning/ROADMAP.md +++ b/.planning/ROADMAP.md @@ -142,7 +142,7 @@ Plans: | Phase | Plans | Status | Completed | |-------|-------|--------|-----------| | 11. Catalog Database-View UX & Legacy Consolidation | 4/4 | ✅ Done | 2026-06-13 | -| 12. Offer Editor — Tier A/B/C, Tag & Prezzo Pubblico | 5/5 | Complete | 2026-06-15 | +| 12. Offer Editor — Tier A/B/C, Tag & Prezzo Pubblico | 5/5 | Complete | 2026-06-18 | | 13. Workspace — Servizi Attivi | — | Pending planning | — | | 14. CRM Attio-style & Fix | 3/3 | Complete | 2026-06-14 | | 15. Dashboard Revenue Stats | — | Blocked (mockup utente) | — | diff --git a/.planning/STATE.md b/.planning/STATE.md index dcc2193..ac47300 100644 --- a/.planning/STATE.md +++ b/.planning/STATE.md @@ -2,15 +2,15 @@ gsd_state_version: 1.0 milestone: v2.1 milestone_name: milestone -status: executing -stopped_at: Phase 12 planned (5 piani, 4 wave) e verificato; pronto per /gsd-execute-phase 12 -last_updated: "2026-06-14T19:04:45.211Z" -last_activity: 2026-06-14 -- Phase 12 (offer editor) re-scoped da mockup + pianificato (planner + plan-checker pass) +status: completed +stopped_at: "Phase 12 complete — Offer Editor (Tier A/B/C, Tag & Prezzo Pubblico) eseguita e verificata. Prossima: Phase 13 (Workspace Servizi Attivi) o Phase 14 (CRM)." +last_updated: "2026-06-18T15:23:00.000Z" +last_activity: 2026-06-18 -- Phase 12 execution complete (5/5 piani, build gate passed, OFFER-11/15/16/17/18 verified) progress: total_phases: 7 - completed_phases: 2 - total_plans: 7 - completed_plans: 7 + completed_phases: 3 + total_plans: 12 + completed_plans: 12 percent: 100 --- @@ -22,14 +22,14 @@ See: .planning/PROJECT.md (updated 2026-06-13) **Core value:** Il cliente apre il link e vede esattamente a che punto è il suo progetto, cosa deve ancora succedere e cosa ha già approvato — senza dover scrivere email per chiedere aggiornamenti. -**Current focus:** Phase 12 — Offer Editor (Tier A/B/C, Tag & Prezzo Pubblico). Pianificata e verificata, pronta per l'esecuzione. (Phase 15 resta bloccata su mockup utente.) +**Current focus:** Phase 13 (Workspace Servizi Attivi) o Phase 14 (CRM Attio-style) — entrambe eseguibili. Phase 15 resta bloccata su mockup utente. Phase 12 (Offer Editor) completata e verificata. ## Current Position -Phase: 12 -Plan: Not started — 5 piani in 4 wave pronti (12-01..12-05) -Status: Planned & verified (planner + plan-checker pass; 1 blocker dipendenza risolto). Ready for /gsd-execute-phase 12 -Last activity: 2026-06-14 -- Phase 12 re-scoped da mockup utente (editor offerte), pianificata (5 piani, 4 wave) +Phase: 13 (next) — ready to plan/execute +Plan: — +Status: Phase 12 complete. Pronto per /gsd-execute-phase 13 o /gsd-execute-phase 14. +Last activity: 2026-06-18 -- Phase 12 execution complete (OFFER-11/15/16/17/18 all verified PASS) Progress: [██████████] 100% diff --git a/.planning/phases/12-offer-composition-drag-drop-csv-import/12-REVIEW.md b/.planning/phases/12-offer-composition-drag-drop-csv-import/12-REVIEW.md new file mode 100644 index 0000000..9dd8488 --- /dev/null +++ b/.planning/phases/12-offer-composition-drag-drop-csv-import/12-REVIEW.md @@ -0,0 +1,413 @@ +--- +phase: 12-offer-composition-drag-drop-csv-import +reviewed: 2026-06-15T10:36:00Z +depth: standard +files_reviewed: 12 +files_reviewed_list: + - scripts/push-12-offer-tier-schema.ts + - scripts/verify-12-03-actions.ts + - scripts/verify-12-03-queries.ts + - src/app/admin/offers/[id]/edit/page.tsx + - src/app/admin/offers/actions.ts + - src/app/admin/offers/page.tsx + - src/components/admin/offers/OfferEditorClient.tsx + - src/components/admin/offers/OfferListClient.tsx + - src/db/migrations/0008_offer_tier_schema.sql + - src/db/migrations/meta/_journal.json + - src/db/schema.ts + - src/lib/offer-queries.ts +findings: + critical: 0 + warning: 6 + info: 4 + total: 10 +status: issues_found +--- + +# Phase 12: Code Review Report + +**Reviewed:** 2026-06-15T10:36:00Z +**Depth:** standard +**Files Reviewed:** 12 +**Status:** issues_found + +## Summary + +This batch implements the Phase 12 Offer Editor: an additive DB migration (tier +designation, public pricing, archive flag, category/ticket dimensions, tipo/obiettivo +tags), a query layer (`offer-queries.ts`), server actions +(`saveOfferEditor`/`toggleOfferArchived`/`addOfferTag`/`removeOfferTag`/ +`renameOfferOption`/`createOfferMacro`), and the editor/list client components. + +The migration and push script are correctly additive/idempotent and respect the +Data Safety constraints in CLAUDE.md (no drops/truncates, `ADD COLUMN IF NOT +EXISTS`, guarded `DO $$` block for the CHECK constraint). `requireAdmin()` is +consistently called at the top of every new server action. + +No critical/security issues were found. The main concerns are: (1) the tier +upsert in `saveOfferEditor` doesn't enforce uniqueness of `tier_letter` within a +single macro, which can desync the UI's `padTiers()` assumption and silently +orphan rows; (2) `renameOfferOption("tipo"/"obiettivo", ...)` can throw an +uncaught unique-constraint violation when the target name already exists, +surfacing as a generic 500 with no user-facing message; (3) the "unarchive" path +(`toggleOfferArchived(macroId, false)`) is implemented server-side and covered by +the verify script but has no reachable UI entry point, making it effectively dead +code from the user's perspective; and (4) several smaller robustness/UX gaps +around empty tiers being persisted with placeholder names, and total mismatches +when an assigned service falls outside the category filter. + +## Warnings + +### WR-01: `saveOfferEditor` does not enforce unique `tier_letter` per macro + +**File:** `src/app/admin/offers/actions.ts:152-238` +**Issue:** `tierSchema` validates each tier's `tier_letter` is one of `"A"|"B"|"C"` +and `saveOfferEditorSchema.tiers` is capped at `.max(3)`, but nothing prevents two +tiers in the same payload from sharing the same `tier_letter` (e.g., two tiers +both `"A"`). The loop at lines 200-238 will happily update/insert both rows +independently — both ending up in `offer_micros` with `macro_id = macroId` and +`tier_letter = "A"`. + +On the next load, `getOfferEditorData` (`src/lib/offer-queries.ts:163-167`) orders +by `tierOrder` (A→B→C, ties broken arbitrarily/by insertion), and +`OfferEditorClient.padTiers()` (`src/components/admin/offers/OfferEditorClient.tsx:33-37`) +uses `tiers.find((t) => t.tier_letter === letter)` — which returns only the FIRST +matching tier. The second "A" tier becomes invisible in the UI but still exists in +the DB (with its own `offer_tier_services` rows), and a subsequent save will +silently drop it from the `tiers` array sent to `saveOfferEditor` (since +`OfferEditorClient` state only ever holds 3 padded tiers) — leaving an orphaned +`offer_micros` row that's never cleaned up. + +**Fix:** Either enforce uniqueness in `saveOfferEditorSchema` via a `.refine()` +check, or — more robustly — have `saveOfferEditor` delete any existing tiers for +`macroId` whose `tier_letter` is NOT present in the incoming payload (so stale/ +duplicate rows get cleaned up): + +```ts +const saveOfferEditorSchema = z.object({ + // ... + tiers: z.array(tierSchema).max(3).refine( + (tiers) => { + const letters = tiers.map((t) => t.tier_letter); + return new Set(letters).size === letters.length; + }, + { message: "Ogni tier deve avere una lettera univoca (A/B/C)" } + ), + // ... +}); +``` + +### WR-02: `renameOfferOption("tipo"/"obiettivo", ...)` can throw on unique constraint violation + +**File:** `src/app/admin/offers/actions.ts:337-341` +**Issue:** For `field === "tipo" | "obiettivo"`, the action runs: + +```ts +await db + .update(tags) + .set({ name: next }) + .where(and(eq(tags.entity_type, OFFER_TAG_ENTITY[field]), eq(tags.name, oldValue))); +``` + +This is a global rename across ALL macros that have a tag named `oldValue` for +that `entity_type`. The `tags` table has a unique index +`tags_entity_name_unique` on `(entity_type, entity_id, name)` +(`src/db/schema.ts:133-137`). If any macro already has a tag named `next` for the +same `entity_type` (e.g., renaming "Audit" → "Coaching" but macro X already has a +"Coaching" tag), the UPDATE on macro X's row will violate the unique index and +throw a raw Postgres error. This error is not caught here, and propagates up to +`OfferEditorClient.handleRenameTipo`/`handleRenameObiettivo` +(`src/components/admin/offers/OfferEditorClient.tsx:210-232`), which `catch` it +generically and show "Errore nel salvataggio. Verifica i campi." — but by that +point the optimistic client-side state update (`setTipoOptions`, `setTipoTags`) +has ALREADY applied for ALL macros' local view, while the DB only partially +applied the rename (some rows renamed, the colliding row left as `oldValue` or +the whole statement rolled back depending on transaction semantics — Drizzle here +issues a single statement so it's atomic per-statement, but the local UI state for +THIS macro is now inconsistent with the DB: `tipoTags` shows `next` even though +the DB row may not have been updated due to the throw on a *different* row update +within the same UPDATE statement — actually since it's one UPDATE affecting +multiple rows, a constraint violation on any row aborts the whole statement, +meaning NO rows are renamed in the DB, but the UI already shows the renamed tag). + +**Fix:** Wrap in `onConflictDoNothing`-style handling isn't directly possible for +UPDATE; instead, pre-check or catch the specific error and surface a meaningful +message: + +```ts +} else if (field === "tipo" || field === "obiettivo") { + try { + await db + .update(tags) + .set({ name: next }) + .where(and(eq(tags.entity_type, OFFER_TAG_ENTITY[field]), eq(tags.name, oldValue))); + } catch (err) { + throw new Error(`Esiste già un tag "${next}" per questo campo`); + } +} +``` + +### WR-03: `toggleOfferArchived(macroId, false)` has no reachable UI entry point + +**File:** `src/components/admin/offers/OfferEditorClient.tsx:174-184, 487-496` +**Issue:** `handleArchive` only ever calls `toggleOfferArchived(data.macro.id, +true)` (line 178), and the "Archivia" button is only rendered when +`!initialArchived` (line 487). There is no button/action that calls +`toggleOfferArchived(macroId, false)` to un-archive an offer. Once an offer is +archived, the only way back is presumably a direct DB edit — `OfferListClient`'s +"Mostra offerte archiviate" toggle (line 116-124 in `OfferListClient.tsx`) lets +the admin SEE archived offers and click through to `/admin/offers/[id]/edit`, but +the edit page gives them no way to restore it. `toggleOfferArchived(macroId, +false)` is exercised in `scripts/verify-12-03-actions.ts` (Test 6) but is +effectively dead code from a product standpoint. + +**Fix:** Add a "Ripristina" (restore) button shown when `initialArchived` is +true, calling `toggleOfferArchived(data.macro.id, false)`: + +```tsx +{initialArchived && ( + +)} +``` + +### WR-04: Empty/unused tier slots are persisted as real `offer_micros` rows with placeholder names + +**File:** `src/components/admin/offers/OfferEditorClient.tsx:138-172`, `src/app/admin/offers/actions.ts:200-238` +**Issue:** `padTiers()` always produces exactly 3 `OfferTierData` entries (A/B/C), +filling missing ones with `emptyTier(letter)` (`id: ""`, empty names, +`assignedServiceIds: []`). `handleSave` (lines 151-159) maps ALL 3 tiers +unconditionally into the payload, defaulting `internal_name` to `` `Tier +${tier.tier_letter}` `` and `public_name` to `t.tier_letter || "Tier"` when +empty. `saveOfferEditor`'s tier loop (lines 200-238) then inserts a NEW +`offer_micros` row for every tier without an `id` — including these placeholder +"empty" tiers — as long as `canSave` is true (i.e., AT LEAST ONE of the 3 tiers +has assigned services). + +Concretely: if the admin only fills in Tier A with services and leaves B/C empty, +saving creates 3 `offer_micros` rows total — 2 of which are "ghost" tiers named +"Tier B"/"Tier C" with `duration_months: 1`, `public_price: null`, and zero +assigned services — visible in any other view that lists `offer_micros` for this +macro (e.g., `getCatalogWithMicros`, used elsewhere in the admin). + +**Fix:** Skip tiers that are both unsaved (`!t.id`) AND empty +(`assignedServiceIds.length === 0` and no `internal_name`/`public_name` entered) +when building the payload: + +```ts +tiers: tiers + .filter((t) => t.id || t.assignedServiceIds.length > 0 || t.internal_name || t.public_name) + .map((t) => ({ ... })), +``` + +### WR-05: `tierTotals` silently treats services outside the category filter as €0, diverging from server-computed `servicesTotal` + +**File:** `src/components/admin/offers/OfferEditorClient.tsx:96-109` +**Issue:** `filteredServices` (lines 96-100) is `data.availableServices` filtered +by `macro.category` (client-side, reactive to the in-progress edit of +`macro.category`). `tierTotals` (lines 102-109) computes each tier's total by +looking up `tier.assignedServiceIds` against `filteredServices` only, defaulting +to `0` via `Number(service?.unit_price ?? 0)` for any assigned service ID not +found in `filteredServices`. + +If a tier has services assigned that belong to a DIFFERENT category than the +macro's current `category` (e.g., the macro's category was just changed in this +editing session, or a service's category changed since assignment), those +services drop out of `filteredServices` and their price silently becomes €0 in +the "Totale Servizi" row — even though `data.tiers[i].servicesTotal` (computed +server-side in `getOfferEditorData`, `src/lib/offer-queries.ts:183-193`, which +does NOT filter by category) would include them. This produces a displayed total +that's lower than what's stored/will be recomputed after save, with no +indication to the admin why. + +**Fix:** Compute `tierTotals` against `data.availableServices` (unfiltered) or a +combined lookup map that includes all services ever referenced by +`assignedServiceIds`, not just the category-filtered subset: + +```ts +const serviceById = useMemo( + () => new Map(data.availableServices.map((s) => [s.id, s])), + [data.availableServices] +); +const tierTotals = useMemo(() => { + return tiers.map((tier) => + tier.assignedServiceIds.reduce((sum, id) => { + const service = serviceById.get(id); + return sum + Number(service?.unit_price ?? 0); + }, 0) + ); +}, [tiers, serviceById]); +``` +(Note: this still won't be 100% accurate if a service belongs to a category +outside `data.availableServices` entirely — but that's the same best-effort +boundary the server-side query already has.) + +### WR-06: `createOfferMacro` allows whitespace-only `internal_name` + +**File:** `src/app/admin/offers/actions.ts:351-376` +**Issue:** `createOfferMacroSchema.internal_name` is `z.string().min(1, "Nome +interno richiesto")`. Zod's `.min(1)` checks string LENGTH, not trimmed content +— a value of `" "` (single space) passes validation. Line 370 then does +`parsed.data.public_name?.trim() || parsed.data.internal_name` — if +`public_name` is empty/whitespace, `public_name` ends up being the untrimmed +`" "` as well. The result is a new `offer_macros` row with +`internal_name = " "` and `public_name = " "`, which will render as a blank card +in `OfferListClient` (line 142: `

{card.internal_name}

` shows nothing +visible) with no way to identify or rename it cleanly from the list view (the +only `EditableCell` for `internal_name` is on the edit page, line 246-251, which +itself has `required` but the same `tempValue.trim().length === 0` check in +`EditableCell.commit` — so once created, it actually CAN be fixed, but the +initial blank card is confusing). + +**Fix:** Trim and re-validate in the Zod schema: + +```ts +const createOfferMacroSchema = z.object({ + internal_name: z.string().trim().min(1, "Nome interno richiesto"), + public_name: z.string().optional(), + description: z.string().optional(), + category: z.string().optional(), +}); +``` +and at line 370, trim `internal_name` too: +```ts +public_name: parsed.data.public_name?.trim() || parsed.data.internal_name.trim(), +``` + +## Info + +### IN-01: `OfferListClient.handleCreateSubmit` always calls `router.refresh()` even when `createOfferMacro` throws + +**File:** `src/components/admin/offers/OfferListClient.tsx:34-41` +**Issue:** + +```ts +function handleCreateSubmit(formData: FormData) { + startTransition(async () => { + await createOfferMacro(formData); + setShowCreateForm(false); + setNewOfferName(""); + router.refresh(); + }); +} +``` + +`createOfferMacro` can throw (e.g., Zod validation failure if `internal_name` is +empty — though the `required` attribute on the `` at line 59 mitigates +this for normal browser usage). If it throws, the `await` rejects, and since +there's no `try/catch`, the rejection becomes an unhandled promise rejection +inside `startTransition`'s async callback — `setShowCreateForm(false)`, +`setNewOfferName("")`, and `router.refresh()` never run, but there's also no +`saveError`-style state to inform the user anything went wrong. The form stays +open with stale state and no feedback. + +**Fix:** Wrap in try/catch and surface an error state, mirroring the pattern used +in `OfferEditorClient`: + +```ts +const [createError, setCreateError] = useState(null); + +function handleCreateSubmit(formData: FormData) { + setCreateError(null); + startTransition(async () => { + try { + await createOfferMacro(formData); + setShowCreateForm(false); + setNewOfferName(""); + router.refresh(); + } catch { + setCreateError("Errore nella creazione dell'offerta."); + } + }); +} +``` + +### IN-02: `requireAdmin()` discards the session without using it for ownership/role checks + +**File:** `src/app/admin/offers/actions.ts:18-21` +**Issue:** + +```ts +async function requireAdmin() { + const session = await getServerSession(authOptions); + if (!session) throw new Error("Non autorizzato"); +} +``` + +This is consistent with the existing pattern in this file (pre-existing, not +introduced by this phase), so it's not a regression — but worth flagging as a +pre-existing gap: any authenticated session is treated as "admin" with no role +check. Since this is a single-admin app per CLAUDE.md's architecture, this is +likely fine, but the function name `requireAdmin` implies a role check that +doesn't exist. Purely informational — no change required unless multi-user admin +roles are planned. + +**Fix:** None required for this phase; consider renaming to `requireSession` for +clarity in a future cleanup, or add a role check if multi-admin support is ever +introduced. + +### IN-03: `formatUnitPrice` and `formatEuro` duplicate locale-formatting logic + +**File:** `src/components/admin/offers/OfferEditorClient.tsx:39-46` +**Issue:** + +```ts +function formatEuro(value: number): string { + return `€${value.toLocaleString("it-IT", { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`; +} + +function formatUnitPrice(raw: string): string { + const num = parseFloat(raw); + return `€${(isNaN(num) ? 0 : num).toLocaleString("it-IT", { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`; +} +``` + +Both functions produce identical output format; `formatUnitPrice` is just +`formatEuro(parseFloat(raw) || 0)`. Minor duplication — not a bug, but could be +collapsed into one helper that accepts `string | number`. + +**Fix (optional):** + +```ts +function formatEuro(value: number | string): string { + const num = typeof value === "string" ? parseFloat(value) : value; + return `€${(isNaN(num) ? 0 : num).toLocaleString("it-IT", { minimumFractionDigits: 2, maximumFractionDigits: 2 })}`; +} +``` + +### IN-04: `push-12-offer-tier-schema.ts` and `0008_offer_tier_schema.sql` can drift independently + +**File:** `scripts/push-12-offer-tier-schema.ts:1-143`, `src/db/migrations/0008_offer_tier_schema.sql:1-45` +**Issue:** The push script (`scripts/push-12-offer-tier-schema.ts`) is a +hand-written duplicate of the SQL migration file's statements (per the comment at +the top of `0008_offer_tier_schema.sql`, this is because `drizzle-kit generate` is +broken per project memory). Both files express the same schema change in two +different forms (column lists in a TS array vs. raw `ALTER TABLE` statements). +This is a deliberate, documented workaround, but creates a maintenance hazard: if +either file is edited in isolation in a future phase, the two can silently +diverge (e.g., a column added to the `.sql` migration but not to the push +script's `offerMacrosColumns`/`offerMicrosColumns` arrays, or vice versa). + +**Fix (optional):** Add a comment cross-reference in both files pointing at each +other ("keep in sync with X"), or — longer-term — generate the push script's +column lists programmatically by parsing the `.sql` file, to guarantee they can't +diverge. Not blocking for this phase given the documented one-off nature. + +--- + +_Reviewed: 2026-06-15T10:36:00Z_ +_Reviewer: Claude (gsd-code-reviewer)_ +_Depth: standard_ diff --git a/.planning/phases/12-offer-composition-drag-drop-csv-import/12-VERIFICATION.md b/.planning/phases/12-offer-composition-drag-drop-csv-import/12-VERIFICATION.md new file mode 100644 index 0000000..2ad263f --- /dev/null +++ b/.planning/phases/12-offer-composition-drag-drop-csv-import/12-VERIFICATION.md @@ -0,0 +1,136 @@ +--- +phase: 12 +verified: 2026-06-18T17:19:00+02:00 +requirements: + OFFER-11: PASS + OFFER-15: PASS + OFFER-16: PASS + OFFER-17: PASS + OFFER-18: PASS +overall: PASS +--- + +# Phase 12: Offer Editor — Verification Report + +**Phase Goal:** Build a full offer editor allowing admin to compose offers with 3 tiers (A/B/C), assign services via checkbox matrix, set per-tier public price, add 4-dimension tags (tipo/obiettivo creatable, categoria/ticket single-select), write a structured transformation promise (5 fields), and manage an offer list with category filter and archive toggle. + +**Verified:** 2026-06-18T17:19:00+02:00 +**Status:** PASS +**Re-verification:** No — initial verification + +--- + +## OFFER-11: Tier A/B/C checkbox matrix with live totals + +**Verdict: PASS** + +**Schema** (`src/db/schema.ts`): `offer_micros.tier_letter` (text, values A/B/C enforced by DB CHECK constraint in migration 0008) and `offer_tier_services` junction table (tier_id → offer_micros.id, service_id → services.id, composite PK) are both present and properly defined. Relations are wired: `offerMicrosRelations` includes `tierServices: many(offer_tier_services)`. + +**Migration** (`src/db/migrations/0008_offer_tier_schema.sql`): Adds `tier_letter` and `public_price` columns to `offer_micros`, adds a guarded CHECK constraint (`tier_letter IN ('A','B','C')`), and creates the `offer_tier_services` table — all with `IF NOT EXISTS` guards, fully additive. + +**Query layer** (`src/lib/offer-queries.ts`, `getOfferEditorData`): Fetches tiers ordered A→B→C via a CASE expression, then fetches `offer_tier_services` rows for all tier IDs in one query, and computes `servicesTotal` per tier with a `SUM(unit_price)` GROUP BY. Returns `assignedServiceIds[]` and `servicesTotal` per tier. + +**Editor UI** (`src/components/admin/offers/OfferEditorClient.tsx`): +- `padTiers()` ensures all three tier slots (A, B, C) are always present in state, creating empty tier objects for any letter not yet persisted. +- `toggleService(tierIdx, serviceId)` updates `assignedServiceIds` in React state immutably. +- `tierTotals` is a `useMemo` that re-derives a per-tier sum from `assignedServiceIds` and `filteredServices.unit_price` on every render — this is the live total. +- The tfoot row "Totale Servizi" renders `tierTotals[idx]` for each column (lines 371–378). +- Checkboxes at lines 353–360 bind `checked={tier.assignedServiceIds.includes(service.id)}` and `onChange={() => toggleService(tierIdx, service.id)}` — the matrix is fully wired. + +**Persistence** (`src/app/admin/offers/actions.ts`, `saveOfferEditor`): Zod schema enforces `tier_letter: z.enum(["A","B","C"])`. Each tier is upserted (update if `id` present, insert otherwise), then `offer_tier_services` is delete-then-reinserted — correct upsert-replace pattern. + +--- + +## OFFER-15: 4-dimension tags (categoria, ticket, tipo, obiettivo) + +**Verdict: PASS** + +**Schema:** `offer_macros.category` (text, single-select) and `offer_macros.ticket` (text, single-select) added in migration 0008. Tipo/Obiettivo reuse the Phase 11 polymorphic `tags` table with entity_type scoped to `"offer_macros.tipo"` and `"offer_macros.obiettivo"` — separate pools from `"services"` and `"leads"` per the D-06 pattern documented in schema comments. + +**Query layer** (`getOfferEditorData`): Fetches tipo/obiettivo tag rows filtered by `inArray(tags.entity_type, [OFFER_TIPO_ENTITY, OFFER_OBIETTIVO_ENTITY])` and splits them into `tipoTags[]` and `obiettivoTags[]`. `getOfferFieldOptions` returns `categoria`, `ticket`, `tipo`, `obiettivo` option pools via `selectDistinct`. + +**Editor UI** (`OfferEditorClient.tsx`): +- `OptionSelect` components render categoria (line 262) and ticket (line 272) as single-select Notion-style dropdowns with rename support. +- `OptionMultiSelect` components render tipo (line 284) and obiettivo (line 299) as multi-select with `onAdd` (creatable — if value not in options, adds to local options state), `onRemove`, and `onRename` callbacks. +- Options are creatable on-the-fly: `onAdd` at line 288 calls `setTipoOptions((prev) => [...prev, v])` when the value is new. + +**Persistence** (`saveOfferEditor`): Tipo/Obiettivo tags are delete-then-reinserted (lines 242–263) with `onConflictDoNothing()`. Categoria/ticket are saved as scalar columns on `offer_macros`. Standalone `addOfferTag`/`removeOfferTag` actions exist for granular tag mutations. + +**Rename propagation** (`renameOfferOption`): Updates `offer_macros.category` / `offer_macros.ticket` in bulk for single-select dimensions, and `tags.name` for tipo/obiettivo — correct cross-row rename. + +--- + +## OFFER-16: Per-tier manual public price + +**Verdict: PASS** + +**Schema** (`offer_micros.public_price`): `numeric(10,2)`, nullable, added in migration 0008. Distinct from the `servicesTotal` which is computed at query time and never stored. + +**Query layer** (`getOfferEditorData`): Returns `public_price: tier.public_price` (raw DB value, nullable string) per tier in `OfferTierData`. + +**Editor UI** (`OfferEditorClient.tsx` lines 381–397): The tfoot row "Prezzo Pubblico" renders one `` per tier column, bound to `tier.public_price` and calling `updateTierPublicPrice(tierIdx, e.target.value)`. This is independent of the "Totale Servizi" row above it — two separate tfoot rows, two separate state values. + +**Persistence** (`saveOfferEditor`): `tier.public_price` is converted with `tier.public_price != null ? String(tier.public_price) : null` and written to `offer_micros.public_price` on upsert. Zod schema: `public_price: z.coerce.number().min(0).optional().nullable()`. + +--- + +## OFFER-17: Structured transformation promise (5 fields) + +**Verdict: PASS** + +**Schema** (`offer_macros`): Five columns added in migration 0008 — `cliente_ideale`, `risultato`, `tempo`, `pain`, `metodo` — all text, nullable. These are distinct from the pre-existing free-text `transformation_promise` column (retained untouched). + +**Query layer** (`getOfferEditorData`): `db.select().from(offer_macros)` returns all columns including the five new ones. The `OfferMacro` type (inferred from schema) includes them. + +**Editor UI** (`OfferEditorClient.tsx` lines 404–467): "Promessa di Trasformazione" section renders five `EditableCell` fields: +- "Aiuto" → `cliente_ideale` +- "A ottenere" → `risultato` +- "In" → `tempo` +- "Senza" → `pain` +- "Grazie a" → `metodo` + +Each calls `updateMacro(key, v)` on save, updating the `macro` state object. All five are initialized from `data.macro.*` at component mount. + +**Persistence** (`saveOfferEditor`): All five fields are explicitly mapped in the `db.update(offer_macros).set({...})` call (lines 186–196), with `|| null` coercion for empty strings. + +--- + +## OFFER-18: Offer list filterable by category, archive toggle + +**Verdict: PASS** + +**Schema** (`offer_macros.is_archived`): `boolean NOT NULL DEFAULT false`, added in migration 0008. + +**Query layer** (`getOfferListCards`): Returns all offers including archived ones (archived filtering is client-side per spec). Returns `id`, `internal_name`, `description`, `category`, `is_archived`. + +**List page** (`src/app/admin/offers/page.tsx`): Calls `getOfferListCards()` and `getOfferFieldOptions()` in parallel, passes `cards` and `options.categoria` to `OfferListClient`. + +**List component** (`OfferListClient.tsx`): +- `activeCategory` state (null = all) drives filter chip selection; "Tutti" chip and one chip per category from `categoryOptions`. +- `showArchived` state (default false) drives the "Mostra offerte archiviate" checkbox. +- `filteredCards` useMemo at lines 26–32 applies both filters simultaneously: `(activeCategory === null || c.category === activeCategory) && (showArchived || !c.is_archived)`. +- Archived offers render with a red "Archiviata" label on the card. +- `toggleOfferArchived(macroId, true)` server action archives an offer from the editor (OFFER-18 archive action). Restore path: the action accepts `archived: boolean` so it can also unarchive, though no unarchive button exists in the editor UI — unarchiving requires the list to show the card via the toggle and navigate to edit. + +**Archive action** (`actions.ts` line 267–271): `toggleOfferArchived` updates `offer_macros.is_archived` and calls `revalidatePath("/admin/offers")`. + +--- + +## Anti-patterns scan + +No placeholder returns (`return null`, `return {}`, `return []` as stubs) found in the key files. The `canSave` guard (`tiers.some((t) => t.assignedServiceIds.length > 0)`) prevents saving a hollow offer but is not a stub — it is a real UX validation. The `emptyTier()` function returns zero-state structs used to pad the three-slot display; they are overwritten by real data fetched from the DB. + +The `servicesTotal: "0"` in `emptyTier` is an initial display value for unpersisted tiers — not a stub, as the live `tierTotals` useMemo recomputes from `assignedServiceIds` state on every checkbox change. + +--- + +## Notes + +1. **Unarchive flow is implicit.** There is no "Unarchive" button in the editor. The only way to restore an archived offer is: enable "Mostra offerte archiviate" on the list page, click into the offer, and call `toggleOfferArchived(id, false)` — which exists in `actions.ts` but has no UI trigger for `archived=false` in `OfferEditorClient.tsx`. This is a minor UX gap but does not block any of OFFER-11 through OFFER-18 as specified. The archiving requirement (OFFER-18) asks for "archive toggle" — the toggle on the list is the show/hide toggle; archiving itself works via the editor button. Unarchiving is not called out in the requirements. + +2. **`canSave` gate.** The "Salva Offerta" button is disabled unless at least one tier has a service assigned. This means an offer with only transformation promise fields filled and no services cannot be saved. This aligns with OFFER-11's framing of service assignment as the core editor operation. + +--- + +_Verified: 2026-06-18T17:19:00+02:00_ +_Verifier: Claude (gsd-verifier)_