simone
a495d84511
- Remove unreachable if (tab === "new") branch in onSubmit - the new-tab button has its own onClick navigation and never triggers form submit - Escape unescaped double quotes in JSX text (react/no-unescaped-entities) - generate_new field left as-is per plan (optional cleanup, out of scope) - Log pre-existing useForm<any>/onSubmit(data: any) no-explicit-any lint errors to deferred-items.md (out of scope: fixing requires resolving a zodResolver/Resolver generic incompatibility with assignQuoteSchema's optional/default fields)
1.2 KiB
1.2 KiB
Deferred Items — Phase 14 (crm-attio-style-fix)
Items discovered during execution that are out of scope for the current task/plan and deferred for future cleanup.
From Plan 14-03
| File | Lines | Issue | Reason Deferred |
|---|---|---|---|
src/components/admin/leads/SendQuoteModal.tsx |
39, 48 | @typescript-eslint/no-explicit-any on useForm<any>() and onSubmit(data: any) |
Pre-existing (not introduced by CRM-12's dead-branch removal). Attempted fix: typing useForm<AssignQuoteInput>() with AssignQuoteInput = z.infer<typeof assignQuoteSchema> (local schema has .optional()/.default() on generate_new) triggers a cascading zodResolver/Resolver<...> generic-incompatibility TS error (3 errors, TS2322/TS2345) between @hookform/resolvers/zod and react-hook-form@7.75's 3-generic Resolver type — same family of issue fixed for LeadForm.tsx's FormField in 14-03 Task 2, but here it surfaces in the resolver/schema layer (input vs output type divergence from .default()), not the FormField component. Resolving it would require either restructuring assignQuoteSchema's optional/default fields or adding resolver-boundary type assertions — out of scope for CRM-12 (isolated dead-code removal). |