26 lines
2.2 KiB
Markdown
26 lines
2.2 KiB
Markdown
# Deferred Items — Phase 14 (crm-attio-style-fix)
|
|
|
|
Items discovered during execution that are out of scope for the current task/plan and deferred for future cleanup.
|
|
|
|
## From Plan 14-01
|
|
|
|
- **`src/app/admin/leads/actions.ts:54`** — pre-existing `@typescript-eslint/no-explicit-any`
|
|
error on `const updateData: Record<string, any> = { updated_at: new Date() };` inside
|
|
`updateLead()`. This function predates Phase 14 and is unchanged by 14-01 (Task 2 only
|
|
appends `updateLeadField`/`addLeadTag`/`removeLeadTag`/`renameLeadTag` after it).
|
|
`npx eslint src/app/admin/leads/actions.ts` exits 1 solely due to this pre-existing line;
|
|
the four new actions added in 14-01 introduce zero new lint errors/warnings.
|
|
Fix: replace `Record<string, any>` with a properly typed partial update object
|
|
(e.g. `Partial<typeof leads.$inferInsert>` or an explicit interface).
|
|
|
|
- **`src/lib/admin-queries.ts`** — pre-existing `@typescript-eslint/no-unused-vars` warnings
|
|
(4x) for imports `settings`, `ServiceCatalog`, `ProjectOffer`, `OfferPhaseService` — these
|
|
predate Phase 14 and are unrelated to the `getLeadsWithTags`/`getLeadFieldOptions` additions
|
|
in Task 1.
|
|
|
|
## From Plan 14-03
|
|
|
|
| File | Lines | Issue | Reason Deferred |
|
|
|------|-------|-------|------------------|
|
|
| `src/components/admin/leads/SendQuoteModal.tsx` | 39, 48 | `@typescript-eslint/no-explicit-any` on `useForm<any>()` and `onSubmit(data: any)` | Pre-existing (not introduced by CRM-12's dead-branch removal). Attempted fix: typing `useForm<AssignQuoteInput>()` with `AssignQuoteInput = z.infer<typeof assignQuoteSchema>` (local schema has `.optional()`/`.default()` on `generate_new`) triggers a cascading `zodResolver`/`Resolver<...>` generic-incompatibility TS error (3 errors, TS2322/TS2345) between `@hookform/resolvers/zod` and `react-hook-form@7.75`'s 3-generic `Resolver` type — same family of issue fixed for `LeadForm.tsx`'s `FormField` in 14-03 Task 2, but here it surfaces in the resolver/schema layer (input vs output type divergence from `.default()`), not the `FormField` component. Resolving it would require either restructuring `assignQuoteSchema`'s optional/default fields or adding resolver-boundary type assertions — out of scope for CRM-12 (isolated dead-code removal). |
|