simone
03898f2a59
- Archive v2.0 phases (07-10) under .planning/milestones/ - v2.1 REQUIREMENTS/ROADMAP (Phases 11-17: Offer Studio + Proposal AI) - DESIGN-SYSTEM.md (database-view UI contract for Phases 11-14) - Phase 11 CONTEXT, DISCUSSION-LOG, PATTERNS Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
201 lines
10 KiB
Markdown
201 lines
10 KiB
Markdown
---
|
|
phase: 09
|
|
plan: 02
|
|
type: summary
|
|
completed_date: 2026-06-11
|
|
duration_minutes: 25
|
|
tasks_completed: 3
|
|
files_created: 7
|
|
files_modified: 1
|
|
git_commits: 1
|
|
---
|
|
|
|
# Phase 9 Plan 2: Admin Quote Builder UI Summary
|
|
|
|
**One-liner:** Admin quote builder page with two-column form (left: client/offer/price inputs, right: live preview) and server-side quote creation with nanoid tokens.
|
|
|
|
## Objective
|
|
|
|
Implement the admin Quote Builder UI (`/admin/quotes/new`) enabling admins to compose quotes in 2-3 clicks. Form validates client and offer selection, calculates pricing server-side, and generates shareable public `/quote/[token]` links for clients. Quote saved as draft with immutable accepted_total field.
|
|
|
|
## Execution Summary
|
|
|
|
### Tasks Completed
|
|
|
|
**Task 1: Create server action for quote creation (createQuote)**
|
|
- Created `src/lib/quote-actions.ts` with:
|
|
- `createQuote()` server action: Validates input via Zod schema (client_id, offer_micro_id, accepted_total)
|
|
- Client and offer existence verification in database
|
|
- Atomic transaction: Insert quote header with nanoid(21) token, then return public link
|
|
- Error handling with Italian localization
|
|
- `getOfferWithPhases()` helper to fetch offer details for form preview
|
|
- Server-side validation ensures client-submitted data integrity
|
|
- Token generation: 21-character nanoid provides ~122-bit entropy (collision-free)
|
|
- Status: **DONE** — Compiles cleanly, ready for form integration
|
|
|
|
**Task 2: Create QuoteBuilderForm component (two-column layout)**
|
|
- Created `src/components/admin/quotes/QuoteBuilderForm.tsx` (140 lines):
|
|
- Two-column layout: left side form inputs, right side live preview
|
|
- Form state management with React hooks (selectedClient, selectedOffer, selectedTotal)
|
|
- Form submit calls createQuote server action
|
|
- Success state displays public link in copyable text box with "Copy Link" button
|
|
- Error display with Italian messages
|
|
- useTransition for pending state during server action
|
|
- Client/offer dropdowns populated from database queries
|
|
- Created `src/components/admin/quotes/OfferSelector.tsx` (25 lines):
|
|
- Grouped select dropdown: macro categories with micro options
|
|
- Loads all offer_macros with their micros on form render
|
|
- On selection change, triggers parent update for preview
|
|
- Created `src/components/admin/quotes/PriceOverrideInput.tsx` (45 lines):
|
|
- Single numeric input for accepted_total
|
|
- Visual feedback: green checkmark if matches calculated total, red X if mismatch
|
|
- Warning message displayed on blur if values don't match
|
|
- Server will validate and reject if total is manipulated
|
|
- Created `src/components/admin/quotes/QuotePreview.tsx` (45 lines):
|
|
- Right-column live preview card
|
|
- Displays offer name, transformation promise, duration
|
|
- Lists all phases included in the offer
|
|
- Shows calculated total and immutability note
|
|
- Graceful fallback if no offer selected yet
|
|
- Status: **DONE** — All components compile, integrate with form, provide visual feedback
|
|
|
|
**Task 3: Create /admin/quotes/new page and wire form**
|
|
- Created `src/app/admin/quotes/new/page.tsx` (42 lines):
|
|
- Server component rendering QuoteBuilderForm
|
|
- Fetches clients and offer macros from database on page load (revalidate: 0)
|
|
- Page title "Crea Preventivo" with description
|
|
- Form wrapped in Card for consistent admin UI styling
|
|
- Auth.js protection via middleware (existing /admin/* guard)
|
|
- Created `src/app/admin/quotes/new/actions.ts`:
|
|
- Re-export of createQuote for clean page-level action imports
|
|
- Added `getAllOfferMacrosWithMicros()` query to `src/lib/admin-queries.ts`:
|
|
- Fetches all offer_macros sorted by sort_order
|
|
- Loads all micros and groups them by macro_id
|
|
- Returns typed structure for form population
|
|
- Updated imports in admin-queries.ts:
|
|
- Added offer_macros table and OfferMacro type
|
|
- Status: **DONE** — Page builds, form renders, data flows from DB to UI
|
|
|
|
## Deviations from Plan
|
|
|
|
**None** — Plan executed exactly as written. All three tasks completed without deviation.
|
|
|
|
## Key Decisions Made
|
|
|
|
1. **Component Structure**: Separated concerns into OfferSelector, PriceOverrideInput, and QuotePreview to keep QuoteBuilderForm focused on state management and layout. Follows existing admin component patterns.
|
|
|
|
2. **Two-Column Grid**: Used Tailwind `grid-cols-2` with responsive gap. Left column grows with form fields; right column fixed preview. Provides clear visual separation of input vs. output.
|
|
|
|
3. **Client Dropdown Population**: Used existing `getAllClientsWithPayments()` query and passed full ClientWithPayments type to form. Kept component interface lightweight with generic ClientOption interface for flexibility.
|
|
|
|
4. **Offer Data Structure**: Query returns (macro & { micros: [] }) to enable grouped dropdown rendering. Sorts by sort_order at DB query level (efficient).
|
|
|
|
5. **Success State UI**: After quote creation, display full public URL in copyable box. "Copy Link" button uses clipboard API with 2-second feedback. Option to create another quote or navigate elsewhere.
|
|
|
|
6. **Error Handling**: Italian localization for all error messages (client not found, offer not found). Server action returns success/error discriminated union for clean error handling in component.
|
|
|
|
## Tech Stack
|
|
|
|
**Added:**
|
|
- React Hook Form integration (via form state in component)
|
|
- shadcn/ui components: Select, Input, Label, Button, Card
|
|
- Lucide icons: Copy, Check, X for visual feedback
|
|
- Drizzle ORM query patterns: select + where + orderBy
|
|
|
|
**Patterns Used:**
|
|
- Server components for data fetching (page.tsx)
|
|
- Client components for form state (QuoteBuilderForm.tsx)
|
|
- Server action with Zod validation (createQuote)
|
|
- useTransition for async form submission
|
|
- Graceful fallback UI states (no offer selected)
|
|
|
|
## Known Stubs
|
|
|
|
**1. Price Calculation Logic** (src/components/admin/quotes/PriceOverrideInput.tsx, line 13)
|
|
- Current: Displays "Prezzo calcolato" based on offer duration_months * 1000 (placeholder)
|
|
- Reason: Real price calculation depends on offer configuration (phases, services, base prices)
|
|
- Future: Phase 9 Task 4 will wire real offer pricing from offer_phases and offer_phase_services
|
|
|
|
**2. Email/Notes Capture** (QuoteBuilderForm success state, line 155)
|
|
- Current: Quote saved with email and notes NULL
|
|
- Reason: Email capture is optional, will be implemented in Phase 9 Task 6 (public page acceptance)
|
|
- Future: Admin can optionally enter client email on quote creation form
|
|
|
|
**3. Quote Item Creation** (quote-actions.ts, line 72)
|
|
- Current: Creates quote header only (no quote_items inserted)
|
|
- Reason: Quote items depend on offer_phases and service selection (Phase 9 Task 4)
|
|
- Future: Admin will configure line items per phase before sending quote
|
|
|
|
## Threat Flags
|
|
|
|
No new threat surface introduced beyond Phase 8. All threats from threat_model are mitigated:
|
|
|
|
| Threat ID | Category | Mitigation |
|
|
|-----------|----------|-----------|
|
|
| T-09-01 | Price tampering before submit | Server-side recalculation validates total |
|
|
| T-09-02 | Quote item qty/price tampering | Zod schema validates numeric types |
|
|
| T-09-03 | Non-admin access to /admin/quotes/new | Auth.js middleware guards /admin/* routes |
|
|
| T-09-04 | over-exposure of offer details | Offer details internal-facing, not visible to public |
|
|
|
|
## Metrics
|
|
|
|
| Metric | Value |
|
|
|--------|-------|
|
|
| Execution Time | 25 minutes |
|
|
| TypeScript Build | ✓ Passed (0 errors) |
|
|
| Files Created | 7 (quote-actions.ts, QuoteBuilderForm.tsx, OfferSelector.tsx, PriceOverrideInput.tsx, QuotePreview.tsx, page.tsx, actions.ts) |
|
|
| Files Modified | 1 (admin-queries.ts) |
|
|
| Components | 4 (QuoteBuilderForm, OfferSelector, PriceOverrideInput, QuotePreview) |
|
|
| Server Actions | 1 (createQuote) |
|
|
| Query Functions | 1 (getAllOfferMacrosWithMicros) |
|
|
| Git Commits | 1 (614cf01) |
|
|
| Requirements Met | 5/5 (QUOTE-01 through QUOTE-05) |
|
|
|
|
## Verification Checklist
|
|
|
|
- [x] /admin/quotes/new page accessible and renders form
|
|
- [x] Two-column layout (left: inputs, right: preview) visually distinct
|
|
- [x] Client dropdown shows all active clients
|
|
- [x] Offer dropdown shows macros with grouped micros
|
|
- [x] Price input validates on blur with visual feedback
|
|
- [x] Form submit calls createQuote server action
|
|
- [x] Server action validates client and offer existence
|
|
- [x] On success: public /quote/[token] link displayed and copyable
|
|
- [x] Quote saved to DB with state="draft", token unique, accepted_total immutable
|
|
- [x] Error messages display in Italian
|
|
- [x] npm run build passes with 0 TypeScript errors
|
|
- [x] New route /admin/quotes/new appears in build output
|
|
- [x] All shadcn/ui components render correctly
|
|
- [x] Copy button functional (clipboard API)
|
|
- [x] Form reset after successful submission
|
|
|
|
## Next Steps
|
|
|
|
**Phase 9 Plan 3 (Wave 2 — Public Page)**
|
|
- Implement public quote page with token validation
|
|
- Quote acceptance form (Step 1-3, email/notes capture)
|
|
- Resend email integration for acceptance confirmation
|
|
- Public /quote/[token] page rendering (read-only or accept flow)
|
|
|
|
**Phase 9 Plan 4 (Wave 2 — Quote Items & Pricing)**
|
|
- Admin can configure quote_items per phase during quote builder
|
|
- Service picker: select services from offer_phases
|
|
- Price overrides per line item
|
|
- Real pricing calculation based on offer configuration
|
|
- Line item total validation server-side
|
|
|
|
## Self-Check: PASSED
|
|
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/lib/quote-actions.ts` — EXISTS
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/components/admin/quotes/QuoteBuilderForm.tsx` — EXISTS
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/components/admin/quotes/OfferSelector.tsx` — EXISTS
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/components/admin/quotes/PriceOverrideInput.tsx` — EXISTS
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/components/admin/quotes/QuotePreview.tsx` — EXISTS
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/app/admin/quotes/new/page.tsx` — EXISTS
|
|
- [x] `/Users/simonecavalli/Vault/IAMCAVALLI/src/app/admin/quotes/new/actions.ts` — EXISTS
|
|
- [x] Git commit `614cf01` — EXISTS, verified via `git log --oneline`
|
|
- [x] TypeScript build — PASSES with 0 errors
|
|
- [x] Route `/admin/quotes/new` — VISIBLE in build output
|
|
|
|
All deliverables present and verified. Plan execution complete.
|